License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 14:07:57 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2017-01-09 15:55:24 +00:00
|
|
|
/*
|
|
|
|
* Shared Memory Communications over RDMA (SMC-R) and RoCE
|
|
|
|
*
|
|
|
|
* Manage RMBE
|
|
|
|
* copy new RMBE data into user space
|
|
|
|
*
|
|
|
|
* Copyright IBM Corp. 2016
|
|
|
|
*
|
|
|
|
* Author(s): Ursula Braun <ubraun@linux.vnet.ibm.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/net.h>
|
|
|
|
#include <linux/rcupdate.h>
|
2017-02-02 07:35:14 +00:00
|
|
|
#include <linux/sched/signal.h>
|
2023-01-26 07:14:21 +00:00
|
|
|
#include <linux/splice.h>
|
2017-02-02 07:35:14 +00:00
|
|
|
|
2017-01-09 15:55:24 +00:00
|
|
|
#include <net/sock.h>
|
2023-01-20 00:45:16 +00:00
|
|
|
#include <trace/events/sock.h>
|
2017-01-09 15:55:24 +00:00
|
|
|
|
|
|
|
#include "smc.h"
|
|
|
|
#include "smc_core.h"
|
|
|
|
#include "smc_cdc.h"
|
|
|
|
#include "smc_tx.h" /* smc_tx_consumer_update() */
|
|
|
|
#include "smc_rx.h"
|
2021-06-16 14:52:55 +00:00
|
|
|
#include "smc_stats.h"
|
2021-11-01 07:39:14 +00:00
|
|
|
#include "smc_tracepoint.h"
|
2017-01-09 15:55:24 +00:00
|
|
|
|
2018-05-03 16:12:37 +00:00
|
|
|
/* callback implementation to wakeup consumers blocked with smc_rx_wait().
|
2017-01-09 15:55:24 +00:00
|
|
|
* indirectly called by smc_cdc_msg_recv_action().
|
|
|
|
*/
|
2018-05-03 16:12:37 +00:00
|
|
|
static void smc_rx_wake_up(struct sock *sk)
|
2017-01-09 15:55:24 +00:00
|
|
|
{
|
|
|
|
struct socket_wq *wq;
|
|
|
|
|
2023-01-20 00:45:16 +00:00
|
|
|
trace_sk_data_ready(sk);
|
|
|
|
|
2017-01-09 15:55:24 +00:00
|
|
|
/* derived from sock_def_readable() */
|
|
|
|
/* called already in smc_listen_work() */
|
|
|
|
rcu_read_lock();
|
|
|
|
wq = rcu_dereference(sk->sk_wq);
|
|
|
|
if (skwq_has_sleeper(wq))
|
2018-02-11 22:34:03 +00:00
|
|
|
wake_up_interruptible_sync_poll(&wq->wait, EPOLLIN | EPOLLPRI |
|
|
|
|
EPOLLRDNORM | EPOLLRDBAND);
|
2024-03-28 14:40:32 +00:00
|
|
|
sk_wake_async_rcu(sk, SOCK_WAKE_WAITD, POLL_IN);
|
2017-01-09 15:55:24 +00:00
|
|
|
if ((sk->sk_shutdown == SHUTDOWN_MASK) ||
|
|
|
|
(sk->sk_state == SMC_CLOSED))
|
2024-03-28 14:40:32 +00:00
|
|
|
sk_wake_async_rcu(sk, SOCK_WAKE_WAITD, POLL_HUP);
|
2017-01-09 15:55:24 +00:00
|
|
|
rcu_read_unlock();
|
|
|
|
}
|
|
|
|
|
2018-05-03 16:12:39 +00:00
|
|
|
/* Update consumer cursor
|
|
|
|
* @conn connection to update
|
|
|
|
* @cons consumer cursor
|
|
|
|
* @len number of Bytes consumed
|
2018-05-23 14:38:11 +00:00
|
|
|
* Returns:
|
|
|
|
* 1 if we should end our receive, 0 otherwise
|
2018-05-03 16:12:39 +00:00
|
|
|
*/
|
2018-05-23 14:38:11 +00:00
|
|
|
static int smc_rx_update_consumer(struct smc_sock *smc,
|
|
|
|
union smc_host_cursor cons, size_t len)
|
2018-05-03 16:12:39 +00:00
|
|
|
{
|
2018-05-23 14:38:11 +00:00
|
|
|
struct smc_connection *conn = &smc->conn;
|
|
|
|
struct sock *sk = &smc->sk;
|
|
|
|
bool force = false;
|
|
|
|
int diff, rc = 0;
|
|
|
|
|
2018-05-18 07:34:10 +00:00
|
|
|
smc_curs_add(conn->rmb_desc->len, &cons, len);
|
2018-05-23 14:38:11 +00:00
|
|
|
|
|
|
|
/* did we process urgent data? */
|
|
|
|
if (conn->urg_state == SMC_URG_VALID || conn->urg_rx_skip_pend) {
|
|
|
|
diff = smc_curs_comp(conn->rmb_desc->len, &cons,
|
|
|
|
&conn->urg_curs);
|
|
|
|
if (sock_flag(sk, SOCK_URGINLINE)) {
|
|
|
|
if (diff == 0) {
|
|
|
|
force = true;
|
|
|
|
rc = 1;
|
|
|
|
conn->urg_state = SMC_URG_READ;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if (diff == 1) {
|
|
|
|
/* skip urgent byte */
|
|
|
|
force = true;
|
|
|
|
smc_curs_add(conn->rmb_desc->len, &cons, 1);
|
|
|
|
conn->urg_rx_skip_pend = false;
|
|
|
|
} else if (diff < -1)
|
|
|
|
/* we read past urgent byte */
|
|
|
|
conn->urg_state = SMC_URG_READ;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-23 11:53:09 +00:00
|
|
|
smc_curs_copy(&conn->local_tx_ctrl.cons, &cons, conn);
|
2018-05-23 14:38:11 +00:00
|
|
|
|
2018-05-03 16:12:39 +00:00
|
|
|
/* send consumer cursor update if required */
|
|
|
|
/* similar to advertising new TCP rcv_wnd if required */
|
2018-05-23 14:38:11 +00:00
|
|
|
smc_tx_consumer_update(conn, force);
|
|
|
|
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void smc_rx_update_cons(struct smc_sock *smc, size_t len)
|
|
|
|
{
|
|
|
|
struct smc_connection *conn = &smc->conn;
|
|
|
|
union smc_host_cursor cons;
|
|
|
|
|
2018-07-23 11:53:09 +00:00
|
|
|
smc_curs_copy(&cons, &conn->local_tx_ctrl.cons, conn);
|
2018-05-23 14:38:11 +00:00
|
|
|
smc_rx_update_consumer(smc, cons, len);
|
2018-05-03 16:12:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
struct smc_spd_priv {
|
|
|
|
struct smc_sock *smc;
|
|
|
|
size_t len;
|
|
|
|
};
|
|
|
|
|
|
|
|
static void smc_rx_pipe_buf_release(struct pipe_inode_info *pipe,
|
|
|
|
struct pipe_buffer *buf)
|
|
|
|
{
|
|
|
|
struct smc_spd_priv *priv = (struct smc_spd_priv *)buf->private;
|
|
|
|
struct smc_sock *smc = priv->smc;
|
|
|
|
struct smc_connection *conn;
|
|
|
|
struct sock *sk = &smc->sk;
|
|
|
|
|
|
|
|
if (sk->sk_state == SMC_CLOSED ||
|
|
|
|
sk->sk_state == SMC_PEERFINCLOSEWAIT ||
|
|
|
|
sk->sk_state == SMC_APPFINCLOSEWAIT)
|
|
|
|
goto out;
|
|
|
|
conn = &smc->conn;
|
|
|
|
lock_sock(sk);
|
2018-05-23 14:38:11 +00:00
|
|
|
smc_rx_update_cons(smc, priv->len);
|
2018-05-03 16:12:39 +00:00
|
|
|
release_sock(sk);
|
|
|
|
if (atomic_sub_and_test(priv->len, &conn->splice_pending))
|
|
|
|
smc_rx_wake_up(sk);
|
|
|
|
out:
|
|
|
|
kfree(priv);
|
|
|
|
put_page(buf->page);
|
|
|
|
sock_put(sk);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct pipe_buf_operations smc_pipe_ops = {
|
|
|
|
.release = smc_rx_pipe_buf_release,
|
|
|
|
.get = generic_pipe_buf_get
|
|
|
|
};
|
|
|
|
|
|
|
|
static void smc_rx_spd_release(struct splice_pipe_desc *spd,
|
|
|
|
unsigned int i)
|
|
|
|
{
|
|
|
|
put_page(spd->pages[i]);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int smc_rx_splice(struct pipe_inode_info *pipe, char *src, size_t len,
|
|
|
|
struct smc_sock *smc)
|
|
|
|
{
|
net/smc: Allow virtually contiguous sndbufs or RMBs for SMC-R
On long-running enterprise production servers, high-order contiguous
memory pages are usually very rare and in most cases we can only get
fragmented pages.
When replacing TCP with SMC-R in such production scenarios, attempting
to allocate high-order physically contiguous sndbufs and RMBs may result
in frequent memory compaction, which will cause unexpected hung issue
and further stability risks.
So this patch is aimed to allow SMC-R link group to use virtually
contiguous sndbufs and RMBs to avoid potential issues mentioned above.
Whether to use physically or virtually contiguous buffers can be set
by sysctl smcr_buf_type.
Note that using virtually contiguous buffers will bring an acceptable
performance regression, which can be mainly divided into two parts:
1) regression in data path, which is brought by additional address
translation of sndbuf by RNIC in Tx. But in general, translating
address through MTT is fast.
Taking 256KB sndbuf and RMB as an example, the comparisons in qperf
latency and bandwidth test with physically and virtually contiguous
buffers are as follows:
- client:
smc_run taskset -c <cpu> qperf <server> -oo msg_size:1:64K:*2\
-t 5 -vu tcp_{bw|lat}
- server:
smc_run taskset -c <cpu> qperf
[latency]
msgsize tcp smcr smcr-use-virt-buf
1 11.17 us 7.56 us 7.51 us (-0.67%)
2 10.65 us 7.74 us 7.56 us (-2.31%)
4 11.11 us 7.52 us 7.59 us ( 0.84%)
8 10.83 us 7.55 us 7.51 us (-0.48%)
16 11.21 us 7.46 us 7.51 us ( 0.71%)
32 10.65 us 7.53 us 7.58 us ( 0.61%)
64 10.95 us 7.74 us 7.80 us ( 0.76%)
128 11.14 us 7.83 us 7.87 us ( 0.47%)
256 10.97 us 7.94 us 7.92 us (-0.28%)
512 11.23 us 7.94 us 8.20 us ( 3.25%)
1024 11.60 us 8.12 us 8.20 us ( 0.96%)
2048 14.04 us 8.30 us 8.51 us ( 2.49%)
4096 16.88 us 9.13 us 9.07 us (-0.64%)
8192 22.50 us 10.56 us 11.22 us ( 6.26%)
16384 28.99 us 12.88 us 13.83 us ( 7.37%)
32768 40.13 us 16.76 us 16.95 us ( 1.16%)
65536 68.70 us 24.68 us 24.85 us ( 0.68%)
[bandwidth]
msgsize tcp smcr smcr-use-virt-buf
1 1.65 MB/s 1.59 MB/s 1.53 MB/s (-3.88%)
2 3.32 MB/s 3.17 MB/s 3.08 MB/s (-2.67%)
4 6.66 MB/s 6.33 MB/s 6.09 MB/s (-3.85%)
8 13.67 MB/s 13.45 MB/s 11.97 MB/s (-10.99%)
16 25.36 MB/s 27.15 MB/s 24.16 MB/s (-11.01%)
32 48.22 MB/s 54.24 MB/s 49.41 MB/s (-8.89%)
64 106.79 MB/s 107.32 MB/s 99.05 MB/s (-7.71%)
128 210.21 MB/s 202.46 MB/s 201.02 MB/s (-0.71%)
256 400.81 MB/s 416.81 MB/s 393.52 MB/s (-5.59%)
512 746.49 MB/s 834.12 MB/s 809.99 MB/s (-2.89%)
1024 1292.33 MB/s 1641.96 MB/s 1571.82 MB/s (-4.27%)
2048 2007.64 MB/s 2760.44 MB/s 2717.68 MB/s (-1.55%)
4096 2665.17 MB/s 4157.44 MB/s 4070.76 MB/s (-2.09%)
8192 3159.72 MB/s 4361.57 MB/s 4270.65 MB/s (-2.08%)
16384 4186.70 MB/s 4574.13 MB/s 4501.17 MB/s (-1.60%)
32768 4093.21 MB/s 4487.42 MB/s 4322.43 MB/s (-3.68%)
65536 4057.14 MB/s 4735.61 MB/s 4555.17 MB/s (-3.81%)
2) regression in buffer initialization and destruction path, which is
brought by additional MR operations of sndbufs. But thanks to link
group buffer reuse mechanism, the impact of this kind of regression
decreases as times of buffer reuse increases.
Taking 256KB sndbuf and RMB as an example, latency of some key SMC-R
buffer-related function obtained by bpftrace are as follows:
Function Phys-bufs Virt-bufs
smcr_new_buf_create() 67154 ns 79164 ns
smc_ib_buf_map_sg() 525 ns 928 ns
smc_ib_get_memory_region() 162294 ns 161191 ns
smc_wr_reg_send() 9957 ns 9635 ns
smc_ib_put_memory_region() 203548 ns 198374 ns
smc_ib_buf_unmap_sg() 508 ns 1158 ns
------------
Test environment notes:
1. Above tests run on 2 VMs within the same Host.
2. The NIC is ConnectX-4Lx, using SRIOV and passing through 2 VFs to
the each VM respectively.
3. VMs' vCPUs are binded to different physical CPUs, and the binded
physical CPUs are isolated by `isolcpus=xxx` cmdline.
4. NICs' queue number are set to 1.
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-07-14 09:44:04 +00:00
|
|
|
struct smc_link_group *lgr = smc->conn.lgr;
|
|
|
|
int offset = offset_in_page(src);
|
|
|
|
struct partial_page *partial;
|
2018-05-03 16:12:39 +00:00
|
|
|
struct splice_pipe_desc spd;
|
net/smc: Allow virtually contiguous sndbufs or RMBs for SMC-R
On long-running enterprise production servers, high-order contiguous
memory pages are usually very rare and in most cases we can only get
fragmented pages.
When replacing TCP with SMC-R in such production scenarios, attempting
to allocate high-order physically contiguous sndbufs and RMBs may result
in frequent memory compaction, which will cause unexpected hung issue
and further stability risks.
So this patch is aimed to allow SMC-R link group to use virtually
contiguous sndbufs and RMBs to avoid potential issues mentioned above.
Whether to use physically or virtually contiguous buffers can be set
by sysctl smcr_buf_type.
Note that using virtually contiguous buffers will bring an acceptable
performance regression, which can be mainly divided into two parts:
1) regression in data path, which is brought by additional address
translation of sndbuf by RNIC in Tx. But in general, translating
address through MTT is fast.
Taking 256KB sndbuf and RMB as an example, the comparisons in qperf
latency and bandwidth test with physically and virtually contiguous
buffers are as follows:
- client:
smc_run taskset -c <cpu> qperf <server> -oo msg_size:1:64K:*2\
-t 5 -vu tcp_{bw|lat}
- server:
smc_run taskset -c <cpu> qperf
[latency]
msgsize tcp smcr smcr-use-virt-buf
1 11.17 us 7.56 us 7.51 us (-0.67%)
2 10.65 us 7.74 us 7.56 us (-2.31%)
4 11.11 us 7.52 us 7.59 us ( 0.84%)
8 10.83 us 7.55 us 7.51 us (-0.48%)
16 11.21 us 7.46 us 7.51 us ( 0.71%)
32 10.65 us 7.53 us 7.58 us ( 0.61%)
64 10.95 us 7.74 us 7.80 us ( 0.76%)
128 11.14 us 7.83 us 7.87 us ( 0.47%)
256 10.97 us 7.94 us 7.92 us (-0.28%)
512 11.23 us 7.94 us 8.20 us ( 3.25%)
1024 11.60 us 8.12 us 8.20 us ( 0.96%)
2048 14.04 us 8.30 us 8.51 us ( 2.49%)
4096 16.88 us 9.13 us 9.07 us (-0.64%)
8192 22.50 us 10.56 us 11.22 us ( 6.26%)
16384 28.99 us 12.88 us 13.83 us ( 7.37%)
32768 40.13 us 16.76 us 16.95 us ( 1.16%)
65536 68.70 us 24.68 us 24.85 us ( 0.68%)
[bandwidth]
msgsize tcp smcr smcr-use-virt-buf
1 1.65 MB/s 1.59 MB/s 1.53 MB/s (-3.88%)
2 3.32 MB/s 3.17 MB/s 3.08 MB/s (-2.67%)
4 6.66 MB/s 6.33 MB/s 6.09 MB/s (-3.85%)
8 13.67 MB/s 13.45 MB/s 11.97 MB/s (-10.99%)
16 25.36 MB/s 27.15 MB/s 24.16 MB/s (-11.01%)
32 48.22 MB/s 54.24 MB/s 49.41 MB/s (-8.89%)
64 106.79 MB/s 107.32 MB/s 99.05 MB/s (-7.71%)
128 210.21 MB/s 202.46 MB/s 201.02 MB/s (-0.71%)
256 400.81 MB/s 416.81 MB/s 393.52 MB/s (-5.59%)
512 746.49 MB/s 834.12 MB/s 809.99 MB/s (-2.89%)
1024 1292.33 MB/s 1641.96 MB/s 1571.82 MB/s (-4.27%)
2048 2007.64 MB/s 2760.44 MB/s 2717.68 MB/s (-1.55%)
4096 2665.17 MB/s 4157.44 MB/s 4070.76 MB/s (-2.09%)
8192 3159.72 MB/s 4361.57 MB/s 4270.65 MB/s (-2.08%)
16384 4186.70 MB/s 4574.13 MB/s 4501.17 MB/s (-1.60%)
32768 4093.21 MB/s 4487.42 MB/s 4322.43 MB/s (-3.68%)
65536 4057.14 MB/s 4735.61 MB/s 4555.17 MB/s (-3.81%)
2) regression in buffer initialization and destruction path, which is
brought by additional MR operations of sndbufs. But thanks to link
group buffer reuse mechanism, the impact of this kind of regression
decreases as times of buffer reuse increases.
Taking 256KB sndbuf and RMB as an example, latency of some key SMC-R
buffer-related function obtained by bpftrace are as follows:
Function Phys-bufs Virt-bufs
smcr_new_buf_create() 67154 ns 79164 ns
smc_ib_buf_map_sg() 525 ns 928 ns
smc_ib_get_memory_region() 162294 ns 161191 ns
smc_wr_reg_send() 9957 ns 9635 ns
smc_ib_put_memory_region() 203548 ns 198374 ns
smc_ib_buf_unmap_sg() 508 ns 1158 ns
------------
Test environment notes:
1. Above tests run on 2 VMs within the same Host.
2. The NIC is ConnectX-4Lx, using SRIOV and passing through 2 VFs to
the each VM respectively.
3. VMs' vCPUs are binded to different physical CPUs, and the binded
physical CPUs are isolated by `isolcpus=xxx` cmdline.
4. NICs' queue number are set to 1.
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-07-14 09:44:04 +00:00
|
|
|
struct smc_spd_priv **priv;
|
|
|
|
struct page **pages;
|
|
|
|
int bytes, nr_pages;
|
|
|
|
int i;
|
2018-05-03 16:12:39 +00:00
|
|
|
|
net/smc: Allow virtually contiguous sndbufs or RMBs for SMC-R
On long-running enterprise production servers, high-order contiguous
memory pages are usually very rare and in most cases we can only get
fragmented pages.
When replacing TCP with SMC-R in such production scenarios, attempting
to allocate high-order physically contiguous sndbufs and RMBs may result
in frequent memory compaction, which will cause unexpected hung issue
and further stability risks.
So this patch is aimed to allow SMC-R link group to use virtually
contiguous sndbufs and RMBs to avoid potential issues mentioned above.
Whether to use physically or virtually contiguous buffers can be set
by sysctl smcr_buf_type.
Note that using virtually contiguous buffers will bring an acceptable
performance regression, which can be mainly divided into two parts:
1) regression in data path, which is brought by additional address
translation of sndbuf by RNIC in Tx. But in general, translating
address through MTT is fast.
Taking 256KB sndbuf and RMB as an example, the comparisons in qperf
latency and bandwidth test with physically and virtually contiguous
buffers are as follows:
- client:
smc_run taskset -c <cpu> qperf <server> -oo msg_size:1:64K:*2\
-t 5 -vu tcp_{bw|lat}
- server:
smc_run taskset -c <cpu> qperf
[latency]
msgsize tcp smcr smcr-use-virt-buf
1 11.17 us 7.56 us 7.51 us (-0.67%)
2 10.65 us 7.74 us 7.56 us (-2.31%)
4 11.11 us 7.52 us 7.59 us ( 0.84%)
8 10.83 us 7.55 us 7.51 us (-0.48%)
16 11.21 us 7.46 us 7.51 us ( 0.71%)
32 10.65 us 7.53 us 7.58 us ( 0.61%)
64 10.95 us 7.74 us 7.80 us ( 0.76%)
128 11.14 us 7.83 us 7.87 us ( 0.47%)
256 10.97 us 7.94 us 7.92 us (-0.28%)
512 11.23 us 7.94 us 8.20 us ( 3.25%)
1024 11.60 us 8.12 us 8.20 us ( 0.96%)
2048 14.04 us 8.30 us 8.51 us ( 2.49%)
4096 16.88 us 9.13 us 9.07 us (-0.64%)
8192 22.50 us 10.56 us 11.22 us ( 6.26%)
16384 28.99 us 12.88 us 13.83 us ( 7.37%)
32768 40.13 us 16.76 us 16.95 us ( 1.16%)
65536 68.70 us 24.68 us 24.85 us ( 0.68%)
[bandwidth]
msgsize tcp smcr smcr-use-virt-buf
1 1.65 MB/s 1.59 MB/s 1.53 MB/s (-3.88%)
2 3.32 MB/s 3.17 MB/s 3.08 MB/s (-2.67%)
4 6.66 MB/s 6.33 MB/s 6.09 MB/s (-3.85%)
8 13.67 MB/s 13.45 MB/s 11.97 MB/s (-10.99%)
16 25.36 MB/s 27.15 MB/s 24.16 MB/s (-11.01%)
32 48.22 MB/s 54.24 MB/s 49.41 MB/s (-8.89%)
64 106.79 MB/s 107.32 MB/s 99.05 MB/s (-7.71%)
128 210.21 MB/s 202.46 MB/s 201.02 MB/s (-0.71%)
256 400.81 MB/s 416.81 MB/s 393.52 MB/s (-5.59%)
512 746.49 MB/s 834.12 MB/s 809.99 MB/s (-2.89%)
1024 1292.33 MB/s 1641.96 MB/s 1571.82 MB/s (-4.27%)
2048 2007.64 MB/s 2760.44 MB/s 2717.68 MB/s (-1.55%)
4096 2665.17 MB/s 4157.44 MB/s 4070.76 MB/s (-2.09%)
8192 3159.72 MB/s 4361.57 MB/s 4270.65 MB/s (-2.08%)
16384 4186.70 MB/s 4574.13 MB/s 4501.17 MB/s (-1.60%)
32768 4093.21 MB/s 4487.42 MB/s 4322.43 MB/s (-3.68%)
65536 4057.14 MB/s 4735.61 MB/s 4555.17 MB/s (-3.81%)
2) regression in buffer initialization and destruction path, which is
brought by additional MR operations of sndbufs. But thanks to link
group buffer reuse mechanism, the impact of this kind of regression
decreases as times of buffer reuse increases.
Taking 256KB sndbuf and RMB as an example, latency of some key SMC-R
buffer-related function obtained by bpftrace are as follows:
Function Phys-bufs Virt-bufs
smcr_new_buf_create() 67154 ns 79164 ns
smc_ib_buf_map_sg() 525 ns 928 ns
smc_ib_get_memory_region() 162294 ns 161191 ns
smc_wr_reg_send() 9957 ns 9635 ns
smc_ib_put_memory_region() 203548 ns 198374 ns
smc_ib_buf_unmap_sg() 508 ns 1158 ns
------------
Test environment notes:
1. Above tests run on 2 VMs within the same Host.
2. The NIC is ConnectX-4Lx, using SRIOV and passing through 2 VFs to
the each VM respectively.
3. VMs' vCPUs are binded to different physical CPUs, and the binded
physical CPUs are isolated by `isolcpus=xxx` cmdline.
4. NICs' queue number are set to 1.
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-07-14 09:44:04 +00:00
|
|
|
nr_pages = !lgr->is_smcd && smc->conn.rmb_desc->is_vm ?
|
|
|
|
PAGE_ALIGN(len + offset) / PAGE_SIZE : 1;
|
|
|
|
|
|
|
|
pages = kcalloc(nr_pages, sizeof(*pages), GFP_KERNEL);
|
|
|
|
if (!pages)
|
|
|
|
goto out;
|
|
|
|
partial = kcalloc(nr_pages, sizeof(*partial), GFP_KERNEL);
|
|
|
|
if (!partial)
|
|
|
|
goto out_page;
|
|
|
|
priv = kcalloc(nr_pages, sizeof(*priv), GFP_KERNEL);
|
2018-05-03 16:12:39 +00:00
|
|
|
if (!priv)
|
net/smc: Allow virtually contiguous sndbufs or RMBs for SMC-R
On long-running enterprise production servers, high-order contiguous
memory pages are usually very rare and in most cases we can only get
fragmented pages.
When replacing TCP with SMC-R in such production scenarios, attempting
to allocate high-order physically contiguous sndbufs and RMBs may result
in frequent memory compaction, which will cause unexpected hung issue
and further stability risks.
So this patch is aimed to allow SMC-R link group to use virtually
contiguous sndbufs and RMBs to avoid potential issues mentioned above.
Whether to use physically or virtually contiguous buffers can be set
by sysctl smcr_buf_type.
Note that using virtually contiguous buffers will bring an acceptable
performance regression, which can be mainly divided into two parts:
1) regression in data path, which is brought by additional address
translation of sndbuf by RNIC in Tx. But in general, translating
address through MTT is fast.
Taking 256KB sndbuf and RMB as an example, the comparisons in qperf
latency and bandwidth test with physically and virtually contiguous
buffers are as follows:
- client:
smc_run taskset -c <cpu> qperf <server> -oo msg_size:1:64K:*2\
-t 5 -vu tcp_{bw|lat}
- server:
smc_run taskset -c <cpu> qperf
[latency]
msgsize tcp smcr smcr-use-virt-buf
1 11.17 us 7.56 us 7.51 us (-0.67%)
2 10.65 us 7.74 us 7.56 us (-2.31%)
4 11.11 us 7.52 us 7.59 us ( 0.84%)
8 10.83 us 7.55 us 7.51 us (-0.48%)
16 11.21 us 7.46 us 7.51 us ( 0.71%)
32 10.65 us 7.53 us 7.58 us ( 0.61%)
64 10.95 us 7.74 us 7.80 us ( 0.76%)
128 11.14 us 7.83 us 7.87 us ( 0.47%)
256 10.97 us 7.94 us 7.92 us (-0.28%)
512 11.23 us 7.94 us 8.20 us ( 3.25%)
1024 11.60 us 8.12 us 8.20 us ( 0.96%)
2048 14.04 us 8.30 us 8.51 us ( 2.49%)
4096 16.88 us 9.13 us 9.07 us (-0.64%)
8192 22.50 us 10.56 us 11.22 us ( 6.26%)
16384 28.99 us 12.88 us 13.83 us ( 7.37%)
32768 40.13 us 16.76 us 16.95 us ( 1.16%)
65536 68.70 us 24.68 us 24.85 us ( 0.68%)
[bandwidth]
msgsize tcp smcr smcr-use-virt-buf
1 1.65 MB/s 1.59 MB/s 1.53 MB/s (-3.88%)
2 3.32 MB/s 3.17 MB/s 3.08 MB/s (-2.67%)
4 6.66 MB/s 6.33 MB/s 6.09 MB/s (-3.85%)
8 13.67 MB/s 13.45 MB/s 11.97 MB/s (-10.99%)
16 25.36 MB/s 27.15 MB/s 24.16 MB/s (-11.01%)
32 48.22 MB/s 54.24 MB/s 49.41 MB/s (-8.89%)
64 106.79 MB/s 107.32 MB/s 99.05 MB/s (-7.71%)
128 210.21 MB/s 202.46 MB/s 201.02 MB/s (-0.71%)
256 400.81 MB/s 416.81 MB/s 393.52 MB/s (-5.59%)
512 746.49 MB/s 834.12 MB/s 809.99 MB/s (-2.89%)
1024 1292.33 MB/s 1641.96 MB/s 1571.82 MB/s (-4.27%)
2048 2007.64 MB/s 2760.44 MB/s 2717.68 MB/s (-1.55%)
4096 2665.17 MB/s 4157.44 MB/s 4070.76 MB/s (-2.09%)
8192 3159.72 MB/s 4361.57 MB/s 4270.65 MB/s (-2.08%)
16384 4186.70 MB/s 4574.13 MB/s 4501.17 MB/s (-1.60%)
32768 4093.21 MB/s 4487.42 MB/s 4322.43 MB/s (-3.68%)
65536 4057.14 MB/s 4735.61 MB/s 4555.17 MB/s (-3.81%)
2) regression in buffer initialization and destruction path, which is
brought by additional MR operations of sndbufs. But thanks to link
group buffer reuse mechanism, the impact of this kind of regression
decreases as times of buffer reuse increases.
Taking 256KB sndbuf and RMB as an example, latency of some key SMC-R
buffer-related function obtained by bpftrace are as follows:
Function Phys-bufs Virt-bufs
smcr_new_buf_create() 67154 ns 79164 ns
smc_ib_buf_map_sg() 525 ns 928 ns
smc_ib_get_memory_region() 162294 ns 161191 ns
smc_wr_reg_send() 9957 ns 9635 ns
smc_ib_put_memory_region() 203548 ns 198374 ns
smc_ib_buf_unmap_sg() 508 ns 1158 ns
------------
Test environment notes:
1. Above tests run on 2 VMs within the same Host.
2. The NIC is ConnectX-4Lx, using SRIOV and passing through 2 VFs to
the each VM respectively.
3. VMs' vCPUs are binded to different physical CPUs, and the binded
physical CPUs are isolated by `isolcpus=xxx` cmdline.
4. NICs' queue number are set to 1.
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-07-14 09:44:04 +00:00
|
|
|
goto out_part;
|
|
|
|
for (i = 0; i < nr_pages; i++) {
|
|
|
|
priv[i] = kzalloc(sizeof(**priv), GFP_KERNEL);
|
|
|
|
if (!priv[i])
|
|
|
|
goto out_priv;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (lgr->is_smcd ||
|
|
|
|
(!lgr->is_smcd && !smc->conn.rmb_desc->is_vm)) {
|
|
|
|
/* smcd or smcr that uses physically contiguous RMBs */
|
|
|
|
priv[0]->len = len;
|
|
|
|
priv[0]->smc = smc;
|
|
|
|
partial[0].offset = src - (char *)smc->conn.rmb_desc->cpu_addr;
|
|
|
|
partial[0].len = len;
|
|
|
|
partial[0].private = (unsigned long)priv[0];
|
|
|
|
pages[0] = smc->conn.rmb_desc->pages;
|
|
|
|
} else {
|
|
|
|
int size, left = len;
|
|
|
|
void *buf = src;
|
|
|
|
/* smcr that uses virtually contiguous RMBs*/
|
|
|
|
for (i = 0; i < nr_pages; i++) {
|
|
|
|
size = min_t(int, PAGE_SIZE - offset, left);
|
|
|
|
priv[i]->len = size;
|
|
|
|
priv[i]->smc = smc;
|
|
|
|
pages[i] = vmalloc_to_page(buf);
|
|
|
|
partial[i].offset = offset;
|
|
|
|
partial[i].len = size;
|
|
|
|
partial[i].private = (unsigned long)priv[i];
|
|
|
|
buf += size / sizeof(*buf);
|
|
|
|
left -= size;
|
|
|
|
offset = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spd.nr_pages_max = nr_pages;
|
|
|
|
spd.nr_pages = nr_pages;
|
|
|
|
spd.pages = pages;
|
|
|
|
spd.partial = partial;
|
2018-05-03 16:12:39 +00:00
|
|
|
spd.ops = &smc_pipe_ops;
|
|
|
|
spd.spd_release = smc_rx_spd_release;
|
|
|
|
|
|
|
|
bytes = splice_to_pipe(pipe, &spd);
|
|
|
|
if (bytes > 0) {
|
|
|
|
sock_hold(&smc->sk);
|
net/smc: Allow virtually contiguous sndbufs or RMBs for SMC-R
On long-running enterprise production servers, high-order contiguous
memory pages are usually very rare and in most cases we can only get
fragmented pages.
When replacing TCP with SMC-R in such production scenarios, attempting
to allocate high-order physically contiguous sndbufs and RMBs may result
in frequent memory compaction, which will cause unexpected hung issue
and further stability risks.
So this patch is aimed to allow SMC-R link group to use virtually
contiguous sndbufs and RMBs to avoid potential issues mentioned above.
Whether to use physically or virtually contiguous buffers can be set
by sysctl smcr_buf_type.
Note that using virtually contiguous buffers will bring an acceptable
performance regression, which can be mainly divided into two parts:
1) regression in data path, which is brought by additional address
translation of sndbuf by RNIC in Tx. But in general, translating
address through MTT is fast.
Taking 256KB sndbuf and RMB as an example, the comparisons in qperf
latency and bandwidth test with physically and virtually contiguous
buffers are as follows:
- client:
smc_run taskset -c <cpu> qperf <server> -oo msg_size:1:64K:*2\
-t 5 -vu tcp_{bw|lat}
- server:
smc_run taskset -c <cpu> qperf
[latency]
msgsize tcp smcr smcr-use-virt-buf
1 11.17 us 7.56 us 7.51 us (-0.67%)
2 10.65 us 7.74 us 7.56 us (-2.31%)
4 11.11 us 7.52 us 7.59 us ( 0.84%)
8 10.83 us 7.55 us 7.51 us (-0.48%)
16 11.21 us 7.46 us 7.51 us ( 0.71%)
32 10.65 us 7.53 us 7.58 us ( 0.61%)
64 10.95 us 7.74 us 7.80 us ( 0.76%)
128 11.14 us 7.83 us 7.87 us ( 0.47%)
256 10.97 us 7.94 us 7.92 us (-0.28%)
512 11.23 us 7.94 us 8.20 us ( 3.25%)
1024 11.60 us 8.12 us 8.20 us ( 0.96%)
2048 14.04 us 8.30 us 8.51 us ( 2.49%)
4096 16.88 us 9.13 us 9.07 us (-0.64%)
8192 22.50 us 10.56 us 11.22 us ( 6.26%)
16384 28.99 us 12.88 us 13.83 us ( 7.37%)
32768 40.13 us 16.76 us 16.95 us ( 1.16%)
65536 68.70 us 24.68 us 24.85 us ( 0.68%)
[bandwidth]
msgsize tcp smcr smcr-use-virt-buf
1 1.65 MB/s 1.59 MB/s 1.53 MB/s (-3.88%)
2 3.32 MB/s 3.17 MB/s 3.08 MB/s (-2.67%)
4 6.66 MB/s 6.33 MB/s 6.09 MB/s (-3.85%)
8 13.67 MB/s 13.45 MB/s 11.97 MB/s (-10.99%)
16 25.36 MB/s 27.15 MB/s 24.16 MB/s (-11.01%)
32 48.22 MB/s 54.24 MB/s 49.41 MB/s (-8.89%)
64 106.79 MB/s 107.32 MB/s 99.05 MB/s (-7.71%)
128 210.21 MB/s 202.46 MB/s 201.02 MB/s (-0.71%)
256 400.81 MB/s 416.81 MB/s 393.52 MB/s (-5.59%)
512 746.49 MB/s 834.12 MB/s 809.99 MB/s (-2.89%)
1024 1292.33 MB/s 1641.96 MB/s 1571.82 MB/s (-4.27%)
2048 2007.64 MB/s 2760.44 MB/s 2717.68 MB/s (-1.55%)
4096 2665.17 MB/s 4157.44 MB/s 4070.76 MB/s (-2.09%)
8192 3159.72 MB/s 4361.57 MB/s 4270.65 MB/s (-2.08%)
16384 4186.70 MB/s 4574.13 MB/s 4501.17 MB/s (-1.60%)
32768 4093.21 MB/s 4487.42 MB/s 4322.43 MB/s (-3.68%)
65536 4057.14 MB/s 4735.61 MB/s 4555.17 MB/s (-3.81%)
2) regression in buffer initialization and destruction path, which is
brought by additional MR operations of sndbufs. But thanks to link
group buffer reuse mechanism, the impact of this kind of regression
decreases as times of buffer reuse increases.
Taking 256KB sndbuf and RMB as an example, latency of some key SMC-R
buffer-related function obtained by bpftrace are as follows:
Function Phys-bufs Virt-bufs
smcr_new_buf_create() 67154 ns 79164 ns
smc_ib_buf_map_sg() 525 ns 928 ns
smc_ib_get_memory_region() 162294 ns 161191 ns
smc_wr_reg_send() 9957 ns 9635 ns
smc_ib_put_memory_region() 203548 ns 198374 ns
smc_ib_buf_unmap_sg() 508 ns 1158 ns
------------
Test environment notes:
1. Above tests run on 2 VMs within the same Host.
2. The NIC is ConnectX-4Lx, using SRIOV and passing through 2 VFs to
the each VM respectively.
3. VMs' vCPUs are binded to different physical CPUs, and the binded
physical CPUs are isolated by `isolcpus=xxx` cmdline.
4. NICs' queue number are set to 1.
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-07-14 09:44:04 +00:00
|
|
|
if (!lgr->is_smcd && smc->conn.rmb_desc->is_vm) {
|
|
|
|
for (i = 0; i < PAGE_ALIGN(bytes + offset) / PAGE_SIZE; i++)
|
|
|
|
get_page(pages[i]);
|
|
|
|
} else {
|
|
|
|
get_page(smc->conn.rmb_desc->pages);
|
|
|
|
}
|
2018-05-03 16:12:39 +00:00
|
|
|
atomic_add(bytes, &smc->conn.splice_pending);
|
|
|
|
}
|
net/smc: Allow virtually contiguous sndbufs or RMBs for SMC-R
On long-running enterprise production servers, high-order contiguous
memory pages are usually very rare and in most cases we can only get
fragmented pages.
When replacing TCP with SMC-R in such production scenarios, attempting
to allocate high-order physically contiguous sndbufs and RMBs may result
in frequent memory compaction, which will cause unexpected hung issue
and further stability risks.
So this patch is aimed to allow SMC-R link group to use virtually
contiguous sndbufs and RMBs to avoid potential issues mentioned above.
Whether to use physically or virtually contiguous buffers can be set
by sysctl smcr_buf_type.
Note that using virtually contiguous buffers will bring an acceptable
performance regression, which can be mainly divided into two parts:
1) regression in data path, which is brought by additional address
translation of sndbuf by RNIC in Tx. But in general, translating
address through MTT is fast.
Taking 256KB sndbuf and RMB as an example, the comparisons in qperf
latency and bandwidth test with physically and virtually contiguous
buffers are as follows:
- client:
smc_run taskset -c <cpu> qperf <server> -oo msg_size:1:64K:*2\
-t 5 -vu tcp_{bw|lat}
- server:
smc_run taskset -c <cpu> qperf
[latency]
msgsize tcp smcr smcr-use-virt-buf
1 11.17 us 7.56 us 7.51 us (-0.67%)
2 10.65 us 7.74 us 7.56 us (-2.31%)
4 11.11 us 7.52 us 7.59 us ( 0.84%)
8 10.83 us 7.55 us 7.51 us (-0.48%)
16 11.21 us 7.46 us 7.51 us ( 0.71%)
32 10.65 us 7.53 us 7.58 us ( 0.61%)
64 10.95 us 7.74 us 7.80 us ( 0.76%)
128 11.14 us 7.83 us 7.87 us ( 0.47%)
256 10.97 us 7.94 us 7.92 us (-0.28%)
512 11.23 us 7.94 us 8.20 us ( 3.25%)
1024 11.60 us 8.12 us 8.20 us ( 0.96%)
2048 14.04 us 8.30 us 8.51 us ( 2.49%)
4096 16.88 us 9.13 us 9.07 us (-0.64%)
8192 22.50 us 10.56 us 11.22 us ( 6.26%)
16384 28.99 us 12.88 us 13.83 us ( 7.37%)
32768 40.13 us 16.76 us 16.95 us ( 1.16%)
65536 68.70 us 24.68 us 24.85 us ( 0.68%)
[bandwidth]
msgsize tcp smcr smcr-use-virt-buf
1 1.65 MB/s 1.59 MB/s 1.53 MB/s (-3.88%)
2 3.32 MB/s 3.17 MB/s 3.08 MB/s (-2.67%)
4 6.66 MB/s 6.33 MB/s 6.09 MB/s (-3.85%)
8 13.67 MB/s 13.45 MB/s 11.97 MB/s (-10.99%)
16 25.36 MB/s 27.15 MB/s 24.16 MB/s (-11.01%)
32 48.22 MB/s 54.24 MB/s 49.41 MB/s (-8.89%)
64 106.79 MB/s 107.32 MB/s 99.05 MB/s (-7.71%)
128 210.21 MB/s 202.46 MB/s 201.02 MB/s (-0.71%)
256 400.81 MB/s 416.81 MB/s 393.52 MB/s (-5.59%)
512 746.49 MB/s 834.12 MB/s 809.99 MB/s (-2.89%)
1024 1292.33 MB/s 1641.96 MB/s 1571.82 MB/s (-4.27%)
2048 2007.64 MB/s 2760.44 MB/s 2717.68 MB/s (-1.55%)
4096 2665.17 MB/s 4157.44 MB/s 4070.76 MB/s (-2.09%)
8192 3159.72 MB/s 4361.57 MB/s 4270.65 MB/s (-2.08%)
16384 4186.70 MB/s 4574.13 MB/s 4501.17 MB/s (-1.60%)
32768 4093.21 MB/s 4487.42 MB/s 4322.43 MB/s (-3.68%)
65536 4057.14 MB/s 4735.61 MB/s 4555.17 MB/s (-3.81%)
2) regression in buffer initialization and destruction path, which is
brought by additional MR operations of sndbufs. But thanks to link
group buffer reuse mechanism, the impact of this kind of regression
decreases as times of buffer reuse increases.
Taking 256KB sndbuf and RMB as an example, latency of some key SMC-R
buffer-related function obtained by bpftrace are as follows:
Function Phys-bufs Virt-bufs
smcr_new_buf_create() 67154 ns 79164 ns
smc_ib_buf_map_sg() 525 ns 928 ns
smc_ib_get_memory_region() 162294 ns 161191 ns
smc_wr_reg_send() 9957 ns 9635 ns
smc_ib_put_memory_region() 203548 ns 198374 ns
smc_ib_buf_unmap_sg() 508 ns 1158 ns
------------
Test environment notes:
1. Above tests run on 2 VMs within the same Host.
2. The NIC is ConnectX-4Lx, using SRIOV and passing through 2 VFs to
the each VM respectively.
3. VMs' vCPUs are binded to different physical CPUs, and the binded
physical CPUs are isolated by `isolcpus=xxx` cmdline.
4. NICs' queue number are set to 1.
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-07-14 09:44:04 +00:00
|
|
|
kfree(priv);
|
|
|
|
kfree(partial);
|
|
|
|
kfree(pages);
|
2018-05-03 16:12:39 +00:00
|
|
|
|
|
|
|
return bytes;
|
net/smc: Allow virtually contiguous sndbufs or RMBs for SMC-R
On long-running enterprise production servers, high-order contiguous
memory pages are usually very rare and in most cases we can only get
fragmented pages.
When replacing TCP with SMC-R in such production scenarios, attempting
to allocate high-order physically contiguous sndbufs and RMBs may result
in frequent memory compaction, which will cause unexpected hung issue
and further stability risks.
So this patch is aimed to allow SMC-R link group to use virtually
contiguous sndbufs and RMBs to avoid potential issues mentioned above.
Whether to use physically or virtually contiguous buffers can be set
by sysctl smcr_buf_type.
Note that using virtually contiguous buffers will bring an acceptable
performance regression, which can be mainly divided into two parts:
1) regression in data path, which is brought by additional address
translation of sndbuf by RNIC in Tx. But in general, translating
address through MTT is fast.
Taking 256KB sndbuf and RMB as an example, the comparisons in qperf
latency and bandwidth test with physically and virtually contiguous
buffers are as follows:
- client:
smc_run taskset -c <cpu> qperf <server> -oo msg_size:1:64K:*2\
-t 5 -vu tcp_{bw|lat}
- server:
smc_run taskset -c <cpu> qperf
[latency]
msgsize tcp smcr smcr-use-virt-buf
1 11.17 us 7.56 us 7.51 us (-0.67%)
2 10.65 us 7.74 us 7.56 us (-2.31%)
4 11.11 us 7.52 us 7.59 us ( 0.84%)
8 10.83 us 7.55 us 7.51 us (-0.48%)
16 11.21 us 7.46 us 7.51 us ( 0.71%)
32 10.65 us 7.53 us 7.58 us ( 0.61%)
64 10.95 us 7.74 us 7.80 us ( 0.76%)
128 11.14 us 7.83 us 7.87 us ( 0.47%)
256 10.97 us 7.94 us 7.92 us (-0.28%)
512 11.23 us 7.94 us 8.20 us ( 3.25%)
1024 11.60 us 8.12 us 8.20 us ( 0.96%)
2048 14.04 us 8.30 us 8.51 us ( 2.49%)
4096 16.88 us 9.13 us 9.07 us (-0.64%)
8192 22.50 us 10.56 us 11.22 us ( 6.26%)
16384 28.99 us 12.88 us 13.83 us ( 7.37%)
32768 40.13 us 16.76 us 16.95 us ( 1.16%)
65536 68.70 us 24.68 us 24.85 us ( 0.68%)
[bandwidth]
msgsize tcp smcr smcr-use-virt-buf
1 1.65 MB/s 1.59 MB/s 1.53 MB/s (-3.88%)
2 3.32 MB/s 3.17 MB/s 3.08 MB/s (-2.67%)
4 6.66 MB/s 6.33 MB/s 6.09 MB/s (-3.85%)
8 13.67 MB/s 13.45 MB/s 11.97 MB/s (-10.99%)
16 25.36 MB/s 27.15 MB/s 24.16 MB/s (-11.01%)
32 48.22 MB/s 54.24 MB/s 49.41 MB/s (-8.89%)
64 106.79 MB/s 107.32 MB/s 99.05 MB/s (-7.71%)
128 210.21 MB/s 202.46 MB/s 201.02 MB/s (-0.71%)
256 400.81 MB/s 416.81 MB/s 393.52 MB/s (-5.59%)
512 746.49 MB/s 834.12 MB/s 809.99 MB/s (-2.89%)
1024 1292.33 MB/s 1641.96 MB/s 1571.82 MB/s (-4.27%)
2048 2007.64 MB/s 2760.44 MB/s 2717.68 MB/s (-1.55%)
4096 2665.17 MB/s 4157.44 MB/s 4070.76 MB/s (-2.09%)
8192 3159.72 MB/s 4361.57 MB/s 4270.65 MB/s (-2.08%)
16384 4186.70 MB/s 4574.13 MB/s 4501.17 MB/s (-1.60%)
32768 4093.21 MB/s 4487.42 MB/s 4322.43 MB/s (-3.68%)
65536 4057.14 MB/s 4735.61 MB/s 4555.17 MB/s (-3.81%)
2) regression in buffer initialization and destruction path, which is
brought by additional MR operations of sndbufs. But thanks to link
group buffer reuse mechanism, the impact of this kind of regression
decreases as times of buffer reuse increases.
Taking 256KB sndbuf and RMB as an example, latency of some key SMC-R
buffer-related function obtained by bpftrace are as follows:
Function Phys-bufs Virt-bufs
smcr_new_buf_create() 67154 ns 79164 ns
smc_ib_buf_map_sg() 525 ns 928 ns
smc_ib_get_memory_region() 162294 ns 161191 ns
smc_wr_reg_send() 9957 ns 9635 ns
smc_ib_put_memory_region() 203548 ns 198374 ns
smc_ib_buf_unmap_sg() 508 ns 1158 ns
------------
Test environment notes:
1. Above tests run on 2 VMs within the same Host.
2. The NIC is ConnectX-4Lx, using SRIOV and passing through 2 VFs to
the each VM respectively.
3. VMs' vCPUs are binded to different physical CPUs, and the binded
physical CPUs are isolated by `isolcpus=xxx` cmdline.
4. NICs' queue number are set to 1.
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-07-14 09:44:04 +00:00
|
|
|
|
|
|
|
out_priv:
|
|
|
|
for (i = (i - 1); i >= 0; i--)
|
|
|
|
kfree(priv[i]);
|
|
|
|
kfree(priv);
|
|
|
|
out_part:
|
|
|
|
kfree(partial);
|
|
|
|
out_page:
|
|
|
|
kfree(pages);
|
|
|
|
out:
|
|
|
|
return -ENOMEM;
|
2018-05-03 16:12:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int smc_rx_data_available_and_no_splice_pend(struct smc_connection *conn)
|
|
|
|
{
|
|
|
|
return atomic_read(&conn->bytes_to_rcv) &&
|
|
|
|
!atomic_read(&conn->splice_pending);
|
|
|
|
}
|
|
|
|
|
2017-01-09 15:55:24 +00:00
|
|
|
/* blocks rcvbuf consumer until >=len bytes available or timeout or interrupted
|
|
|
|
* @smc smc socket
|
|
|
|
* @timeo pointer to max seconds to wait, pointer to value 0 for no timeout
|
2018-05-03 16:12:37 +00:00
|
|
|
* @fcrit add'l criterion to evaluate as function pointer
|
2017-01-09 15:55:24 +00:00
|
|
|
* Returns:
|
|
|
|
* 1 if at least 1 byte available in rcvbuf or if socket error/shutdown.
|
|
|
|
* 0 otherwise (nothing in rcvbuf nor timeout, e.g. interrupted).
|
|
|
|
*/
|
2018-05-03 16:12:37 +00:00
|
|
|
int smc_rx_wait(struct smc_sock *smc, long *timeo,
|
|
|
|
int (*fcrit)(struct smc_connection *conn))
|
2017-01-09 15:55:24 +00:00
|
|
|
{
|
|
|
|
DEFINE_WAIT_FUNC(wait, woken_wake_function);
|
|
|
|
struct smc_connection *conn = &smc->conn;
|
2019-10-21 14:13:08 +00:00
|
|
|
struct smc_cdc_conn_state_flags *cflags =
|
|
|
|
&conn->local_tx_ctrl.conn_state_flags;
|
2017-01-09 15:55:24 +00:00
|
|
|
struct sock *sk = &smc->sk;
|
|
|
|
int rc;
|
|
|
|
|
2018-05-03 16:12:37 +00:00
|
|
|
if (fcrit(conn))
|
2017-01-09 15:55:24 +00:00
|
|
|
return 1;
|
|
|
|
sk_set_bit(SOCKWQ_ASYNC_WAITDATA, sk);
|
|
|
|
add_wait_queue(sk_sleep(sk), &wait);
|
|
|
|
rc = sk_wait_event(sk, timeo,
|
2023-05-09 18:29:48 +00:00
|
|
|
READ_ONCE(sk->sk_err) ||
|
2019-10-21 14:13:08 +00:00
|
|
|
cflags->peer_conn_abort ||
|
2023-05-09 18:29:48 +00:00
|
|
|
READ_ONCE(sk->sk_shutdown) & RCV_SHUTDOWN ||
|
2019-10-21 14:13:08 +00:00
|
|
|
conn->killed ||
|
2019-10-10 08:16:10 +00:00
|
|
|
fcrit(conn),
|
2017-01-09 15:55:24 +00:00
|
|
|
&wait);
|
|
|
|
remove_wait_queue(sk_sleep(sk), &wait);
|
|
|
|
sk_clear_bit(SOCKWQ_ASYNC_WAITDATA, sk);
|
|
|
|
return rc;
|
|
|
|
}
|
|
|
|
|
2018-05-23 14:38:11 +00:00
|
|
|
static int smc_rx_recv_urg(struct smc_sock *smc, struct msghdr *msg, int len,
|
|
|
|
int flags)
|
|
|
|
{
|
|
|
|
struct smc_connection *conn = &smc->conn;
|
|
|
|
union smc_host_cursor cons;
|
|
|
|
struct sock *sk = &smc->sk;
|
|
|
|
int rc = 0;
|
|
|
|
|
|
|
|
if (sock_flag(sk, SOCK_URGINLINE) ||
|
|
|
|
!(conn->urg_state == SMC_URG_VALID) ||
|
|
|
|
conn->urg_state == SMC_URG_READ)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2021-06-16 14:52:58 +00:00
|
|
|
SMC_STAT_INC(smc, urg_data_cnt);
|
2018-05-23 14:38:11 +00:00
|
|
|
if (conn->urg_state == SMC_URG_VALID) {
|
|
|
|
if (!(flags & MSG_PEEK))
|
|
|
|
smc->conn.urg_state = SMC_URG_READ;
|
|
|
|
msg->msg_flags |= MSG_OOB;
|
|
|
|
if (len > 0) {
|
|
|
|
if (!(flags & MSG_TRUNC))
|
|
|
|
rc = memcpy_to_msg(msg, &conn->urg_rx_byte, 1);
|
|
|
|
len = 1;
|
2018-07-23 11:53:09 +00:00
|
|
|
smc_curs_copy(&cons, &conn->local_tx_ctrl.cons, conn);
|
2018-05-23 14:38:11 +00:00
|
|
|
if (smc_curs_diff(conn->rmb_desc->len, &cons,
|
|
|
|
&conn->urg_curs) > 1)
|
|
|
|
conn->urg_rx_skip_pend = true;
|
|
|
|
/* Urgent Byte was already accounted for, but trigger
|
|
|
|
* skipping the urgent byte in non-inline case
|
|
|
|
*/
|
|
|
|
if (!(flags & MSG_PEEK))
|
|
|
|
smc_rx_update_consumer(smc, cons, 0);
|
|
|
|
} else {
|
|
|
|
msg->msg_flags |= MSG_TRUNC;
|
|
|
|
}
|
|
|
|
|
|
|
|
return rc ? -EFAULT : len;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (sk->sk_state == SMC_CLOSED || sk->sk_shutdown & RCV_SHUTDOWN)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
return -EAGAIN;
|
|
|
|
}
|
|
|
|
|
2019-10-10 08:16:11 +00:00
|
|
|
static bool smc_rx_recvmsg_data_available(struct smc_sock *smc)
|
|
|
|
{
|
|
|
|
struct smc_connection *conn = &smc->conn;
|
|
|
|
|
|
|
|
if (smc_rx_data_available(conn))
|
|
|
|
return true;
|
|
|
|
else if (conn->urg_state == SMC_URG_VALID)
|
|
|
|
/* we received a single urgent Byte - skip */
|
|
|
|
smc_rx_update_cons(smc, 0);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-05-03 16:12:39 +00:00
|
|
|
/* smc_rx_recvmsg - receive data from RMBE
|
|
|
|
* @msg: copy data to receive buffer
|
|
|
|
* @pipe: copy data to pipe if set - indicates splice() call
|
|
|
|
*
|
|
|
|
* rcvbuf consumer: main API called by socket layer.
|
|
|
|
* Called under sk lock.
|
2017-01-09 15:55:24 +00:00
|
|
|
*/
|
2018-05-03 16:12:39 +00:00
|
|
|
int smc_rx_recvmsg(struct smc_sock *smc, struct msghdr *msg,
|
|
|
|
struct pipe_inode_info *pipe, size_t len, int flags)
|
2017-01-09 15:55:24 +00:00
|
|
|
{
|
|
|
|
size_t copylen, read_done = 0, read_remaining = len;
|
|
|
|
size_t chunk_len, chunk_off, chunk_len_sum;
|
|
|
|
struct smc_connection *conn = &smc->conn;
|
2018-05-03 16:12:39 +00:00
|
|
|
int (*func)(struct smc_connection *conn);
|
2017-01-09 15:55:24 +00:00
|
|
|
union smc_host_cursor cons;
|
|
|
|
int readable, chunk;
|
|
|
|
char *rcvbuf_base;
|
|
|
|
struct sock *sk;
|
2018-05-03 16:12:39 +00:00
|
|
|
int splbytes;
|
2017-01-09 15:55:24 +00:00
|
|
|
long timeo;
|
|
|
|
int target; /* Read at least these many bytes */
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
if (unlikely(flags & MSG_ERRQUEUE))
|
|
|
|
return -EINVAL; /* future work for sk.sk_family == AF_SMC */
|
|
|
|
|
|
|
|
sk = &smc->sk;
|
|
|
|
if (sk->sk_state == SMC_LISTEN)
|
|
|
|
return -ENOTCONN;
|
2018-05-23 14:38:11 +00:00
|
|
|
if (flags & MSG_OOB)
|
|
|
|
return smc_rx_recv_urg(smc, msg, len, flags);
|
2017-01-09 15:55:24 +00:00
|
|
|
timeo = sock_rcvtimeo(sk, flags & MSG_DONTWAIT);
|
|
|
|
target = sock_rcvlowat(sk, flags & MSG_WAITALL, len);
|
|
|
|
|
2021-06-16 14:52:55 +00:00
|
|
|
readable = atomic_read(&conn->bytes_to_rcv);
|
|
|
|
if (readable >= conn->rmb_desc->len)
|
2021-06-16 14:52:58 +00:00
|
|
|
SMC_STAT_RMB_RX_FULL(smc, !conn->lnk);
|
2021-06-16 14:52:55 +00:00
|
|
|
|
|
|
|
if (len < readable)
|
2021-06-16 14:52:58 +00:00
|
|
|
SMC_STAT_RMB_RX_SIZE_SMALL(smc, !conn->lnk);
|
2017-01-09 15:55:24 +00:00
|
|
|
/* we currently use 1 RMBE per RMB, so RMBE == RMB base addr */
|
2018-06-28 17:05:10 +00:00
|
|
|
rcvbuf_base = conn->rx_off + conn->rmb_desc->cpu_addr;
|
2017-01-09 15:55:24 +00:00
|
|
|
|
|
|
|
do { /* while (read_remaining) */
|
2018-05-03 16:12:39 +00:00
|
|
|
if (read_done >= target || (pipe && read_done))
|
2017-01-09 15:55:24 +00:00
|
|
|
break;
|
|
|
|
|
2019-10-21 14:13:08 +00:00
|
|
|
if (conn->killed)
|
|
|
|
break;
|
|
|
|
|
2019-10-10 08:16:11 +00:00
|
|
|
if (smc_rx_recvmsg_data_available(smc))
|
2017-01-09 15:55:24 +00:00
|
|
|
goto copy;
|
|
|
|
|
2019-10-21 14:13:08 +00:00
|
|
|
if (sk->sk_shutdown & RCV_SHUTDOWN) {
|
2019-10-10 08:16:11 +00:00
|
|
|
/* smc_cdc_msg_recv_action() could have run after
|
|
|
|
* above smc_rx_recvmsg_data_available()
|
|
|
|
*/
|
|
|
|
if (smc_rx_recvmsg_data_available(smc))
|
|
|
|
goto copy;
|
2018-05-03 16:12:36 +00:00
|
|
|
break;
|
2019-10-10 08:16:11 +00:00
|
|
|
}
|
2018-05-03 16:12:36 +00:00
|
|
|
|
2017-01-09 15:55:24 +00:00
|
|
|
if (read_done) {
|
|
|
|
if (sk->sk_err ||
|
|
|
|
sk->sk_state == SMC_CLOSED ||
|
|
|
|
!timeo ||
|
2018-05-03 16:12:36 +00:00
|
|
|
signal_pending(current))
|
2017-01-09 15:55:24 +00:00
|
|
|
break;
|
|
|
|
} else {
|
|
|
|
if (sk->sk_err) {
|
|
|
|
read_done = sock_error(sk);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (sk->sk_state == SMC_CLOSED) {
|
|
|
|
if (!sock_flag(sk, SOCK_DONE)) {
|
|
|
|
/* This occurs when user tries to read
|
|
|
|
* from never connected socket.
|
|
|
|
*/
|
|
|
|
read_done = -ENOTCONN;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
2022-05-12 03:08:20 +00:00
|
|
|
if (!timeo)
|
|
|
|
return -EAGAIN;
|
2017-01-09 15:55:24 +00:00
|
|
|
if (signal_pending(current)) {
|
|
|
|
read_done = sock_intr_errno(timeo);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-05-03 16:12:37 +00:00
|
|
|
if (!smc_rx_data_available(conn)) {
|
|
|
|
smc_rx_wait(smc, &timeo, smc_rx_data_available);
|
2017-01-09 15:55:24 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
copy:
|
|
|
|
/* initialize variables for 1st iteration of subsequent loop */
|
2018-05-03 16:12:37 +00:00
|
|
|
/* could be just 1 byte, even after waiting on data above */
|
2017-01-09 15:55:24 +00:00
|
|
|
readable = atomic_read(&conn->bytes_to_rcv);
|
2018-05-03 16:12:39 +00:00
|
|
|
splbytes = atomic_read(&conn->splice_pending);
|
|
|
|
if (!readable || (msg && splbytes)) {
|
|
|
|
if (splbytes)
|
|
|
|
func = smc_rx_data_available_and_no_splice_pend;
|
|
|
|
else
|
|
|
|
func = smc_rx_data_available;
|
|
|
|
smc_rx_wait(smc, &timeo, func);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2018-07-23 11:53:09 +00:00
|
|
|
smc_curs_copy(&cons, &conn->local_tx_ctrl.cons, conn);
|
2018-05-03 16:12:39 +00:00
|
|
|
/* subsequent splice() calls pick up where previous left */
|
|
|
|
if (splbytes)
|
2018-05-18 07:34:10 +00:00
|
|
|
smc_curs_add(conn->rmb_desc->len, &cons, splbytes);
|
2018-05-23 14:38:11 +00:00
|
|
|
if (conn->urg_state == SMC_URG_VALID &&
|
|
|
|
sock_flag(&smc->sk, SOCK_URGINLINE) &&
|
|
|
|
readable > 1)
|
|
|
|
readable--; /* always stop at urgent Byte */
|
|
|
|
/* not more than what user space asked for */
|
|
|
|
copylen = min_t(size_t, read_remaining, readable);
|
2017-01-09 15:55:24 +00:00
|
|
|
/* determine chunks where to read from rcvbuf */
|
|
|
|
/* either unwrapped case, or 1st chunk of wrapped case */
|
2018-05-18 07:34:10 +00:00
|
|
|
chunk_len = min_t(size_t, copylen, conn->rmb_desc->len -
|
|
|
|
cons.count);
|
2017-01-09 15:55:24 +00:00
|
|
|
chunk_len_sum = chunk_len;
|
|
|
|
chunk_off = cons.count;
|
2017-07-28 11:56:22 +00:00
|
|
|
smc_rmb_sync_sg_for_cpu(conn);
|
2017-01-09 15:55:24 +00:00
|
|
|
for (chunk = 0; chunk < 2; chunk++) {
|
|
|
|
if (!(flags & MSG_TRUNC)) {
|
2018-05-03 16:12:39 +00:00
|
|
|
if (msg) {
|
|
|
|
rc = memcpy_to_msg(msg, rcvbuf_base +
|
|
|
|
chunk_off,
|
|
|
|
chunk_len);
|
|
|
|
} else {
|
|
|
|
rc = smc_rx_splice(pipe, rcvbuf_base +
|
|
|
|
chunk_off, chunk_len,
|
|
|
|
smc);
|
|
|
|
}
|
|
|
|
if (rc < 0) {
|
2017-01-09 15:55:24 +00:00
|
|
|
if (!read_done)
|
|
|
|
read_done = -EFAULT;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
read_remaining -= chunk_len;
|
|
|
|
read_done += chunk_len;
|
|
|
|
|
|
|
|
if (chunk_len_sum == copylen)
|
|
|
|
break; /* either on 1st or 2nd iteration */
|
|
|
|
/* prepare next (== 2nd) iteration */
|
|
|
|
chunk_len = copylen - chunk_len; /* remainder */
|
|
|
|
chunk_len_sum += chunk_len;
|
|
|
|
chunk_off = 0; /* modulo offset in recv ring buffer */
|
|
|
|
}
|
|
|
|
|
|
|
|
/* update cursors */
|
|
|
|
if (!(flags & MSG_PEEK)) {
|
|
|
|
/* increased in recv tasklet smc_cdc_msg_rcv() */
|
|
|
|
smp_mb__before_atomic();
|
|
|
|
atomic_sub(copylen, &conn->bytes_to_rcv);
|
2018-05-18 07:34:10 +00:00
|
|
|
/* guarantee 0 <= bytes_to_rcv <= rmb_desc->len */
|
2017-01-09 15:55:24 +00:00
|
|
|
smp_mb__after_atomic();
|
2018-05-23 14:38:11 +00:00
|
|
|
if (msg && smc_rx_update_consumer(smc, cons, copylen))
|
|
|
|
goto out;
|
2017-01-09 15:55:24 +00:00
|
|
|
}
|
2021-11-01 07:39:14 +00:00
|
|
|
|
|
|
|
trace_smc_rx_recvmsg(smc, copylen);
|
2017-01-09 15:55:24 +00:00
|
|
|
} while (read_remaining);
|
|
|
|
out:
|
|
|
|
return read_done;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Initialize receive properties on connection establishment. NB: not __init! */
|
|
|
|
void smc_rx_init(struct smc_sock *smc)
|
|
|
|
{
|
2018-05-03 16:12:37 +00:00
|
|
|
smc->sk.sk_data_ready = smc_rx_wake_up;
|
2018-05-03 16:12:39 +00:00
|
|
|
atomic_set(&smc->conn.splice_pending, 0);
|
2018-05-23 14:38:11 +00:00
|
|
|
smc->conn.urg_state = SMC_URG_READ;
|
2017-01-09 15:55:24 +00:00
|
|
|
}
|